SQLite: Fix wrongly detected reference constraint name on schema change

[MyIgel]

Q	A
Type	bug
BC Break	no?
Fixed issues	#4243

Summary

This fixes #4243 as other parts of the code expect the constraint name to be null, for example \Doctrine\DBAL\Schema\ForeignKeyConstraint::__construct if no actual name exists

[greg0ire]

I'd expect #4243 (comment) to be summarized in the commit message body, right now it's quite hard to understand what is going on here from the commit message alone.

[morozov]

Thank you for the PR, @MyIgel. Please make sure there's a functional test that reproduces the problem. The changes in the existing test are clear enough but insufficient.

[MyIgel]

Please make sure there's a functional test that reproduces the problem.

@morozov Do you have an example how such a test would look like? #4244 should be a good start but as i have no overview about the dbal tests some hints would be nice here :)

[MyIgel]

I'd expect #4243 (comment) to be summarized in the commit message body

I added a more verbose explanation, i hope its more understandable now

[morozov]

@MyIgel sorry, I didn't notice that the test being changed is a functional one. The change looks good to me given the explanation in #4243 (comment).

[greg0ire]

i hope its more understandable now

It's a great commit message, you can be proud of it!

[greg0ire]

Thanks @MyIgel !