Restore PDOStatement::quote() for backward compatibility

[morozov]

Fixes #4281.

[greg0ire]

The code looks good

well, int is a valid type according to the API

Is it really? I don't know what phpdoc we inherit but the signature says this should be a string: https://www.php.net/manual/en/pdo.quote.php

Also, it's a bit weird that PHPstan does not complain for this test… maybe it's a new rule, or maybe it's a level above the one we currently use.

[morozov]

Is it really? I don't know what phpdoc we inherit but the signature says this should be a string:

It is. This is the phpdoc PDOConnection inherits that says it's a mixed:

dbal/lib/Doctrine/DBAL/Driver/Connection.php

Lines 31 to 39 in b5e1599

	/**
	* Quotes a string for use in a query.
	*
	* @param mixed $value
	* @param int $type
	*
	* @return mixed
	*/
	public function quote($value, $type = ParameterType::STRING);

Take this code for example:

$conn = DriverManager::getConnection(
    'driver' => 'pdo_sqlite',
    'dbname' => 'sqlite::memory:',
)->getWrappedConnection();

For the caller, $conn above is just a Driver\Connection (which accepts mixed). The caller doesn't know that it's also a PDOConnection which extends PDO (which accepts string).

Furthermore, some other drivers explicitly handle the non-string values in quote():

dbal/lib/Doctrine/DBAL/Driver/OCI8/OCI8Connection.php

Lines 129 to 133 in b5e1599

	public function quote($value, $type = ParameterType::STRING)
	{
	if (is_int($value) || is_float($value)) {
	return $value;
	}

Also, it's a bit weird that PHPstan does not complain for this test

We don't run PHPStan on tests in 2.x:

dbal/phpstan.neon.dist

Lines 3 to 5 in b5e1599

	paths:
	- %currentWorkingDirectory%/lib
	reportUnmatchedIgnoredErrors: false

I tried enabling them quite some time ago and gave up because it was close to impossible w/o suppressing hundreds of errors or breaking BC. At that time, it wasn't clear that 2.x would be supported for that much longer.

[SenseException]

Since 2.10.x won't get this fix, this PR looks goot to me.

[greg0ire]

Thanks for the explanation @morozov , very clear!