-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge release 2.12.0 into 3.0.x #4379
Closed
github-actions
wants to merge
25
commits into
3.0.x
from
2.12.x-merge-up-into-3.0.x_5f91cf8a00c230.67462317
Closed
Merge release 2.12.0 into 3.0.x #4379
github-actions
wants to merge
25
commits into
3.0.x
from
2.12.x-merge-up-into-3.0.x_5f91cf8a00c230.67462317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[2.12] PHP 8 compatibility
It has support for PHP8.
That test will get remove in next major release, and requires too much maintenance.
Jobs that use other versions of PHP are temporarily removed so that it's easier to focus and iterate.
This leverages a new feature of shivammathur/setup-php that allows to fail the build if an extension or tool fails to install.
Move the logic out of the assertion
My IDE was telling me I was trying to catch a non-existent exception, however it's clear by digging down a level that the Exception is throw by this class, so this simply annotates that. Perhaps this should catch it and throw a QueryException?
Test the newest version, the oldest version, and versions for which we have version-specific code. This is based on platform classes that have a version number in their name.
Psalm fails on release commits
Fail on extension / tool installation failure
…notation Adds exception thrown by execute() method
Reduce number of build jobs
Configuration should not be internal
morozov
deleted the
2.12.x-merge-up-into-3.0.x_5f91cf8a00c230.67462317
branch
October 22, 2020 18:52
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 2.12.0
2.12.0
Documentation,Static Analysis
CI
Bug,Static Analysis
Documentation,Error Handling
CI,PHP
PHP