Proofread upgrade guide #4384
Proofread upgrade guide #4384
Conversation
UPGRADE.md
Outdated
| @@ -200,7 +199,7 @@ The `Doctrine\DBAL\Driver::getName()` has been removed. | |||
|
|
|||
| ## BC BREAK changes the `Driver::connect()` signature | |||
|
|
|||
| The method no longer accepts the `$username`, `$password` and `$driverOptions` arguments. The corresponding values are expected to be passed as the "user", "password" and "driver_options" keys of the `$params` argument respectively. | |||
| The method no longer accepts the `$username`, `$password` and `$driverOptions` arguments. The corresponding values are expected to be passed as the `user`, `password` and `driver_options` keys of the `$params` argument respectively. | |||
There was a problem hiding this comment.
These are not symbols but strings. I'd format them as "user", etc.
There was a problem hiding this comment.
IMO array keys still deserve that formatting, especially since driver_options contains an underscore, but also because the user will get an issue if they misspell these strings.
There was a problem hiding this comment.
I meant both formatting as code and quotes.
There was a problem hiding this comment.
I spent 5 minutes before answering, googling how to represent a backtick as code in markdown and gave up, although I remember I found a solution earlier.
There was a problem hiding this comment.
You can edit my message to see how
`"hi"`
This is where I found it: https://meta.stackexchange.com/questions/82718/how-do-i-escape-a-backtick-within-in-line-code-in-markdown
There was a problem hiding this comment.
How fun is it? This is the article I had found earlier!
greg0ire
force-pushed
the
proofread-upgrade-guide
branch
from
fd2cf14
to
22a95b2
Compare
|
Thanks, @greg0ire, for the cleanup 👍 |
No description provided.