-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mysql] ignore index length for spatial indexes #4525
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
reviewed
Mar 2, 2021
tests/Doctrine/Tests/DBAL/Functional/Schema/MySqlSchemaManagerTest.php
Outdated
Show resolved
Hide resolved
ottaviano
force-pushed
the
spatial-index-length
branch
from
March 2, 2021 08:31
0e7bad6
to
74f661d
Compare
@ottaviano, looks good. I just ran the new test w/o the fix, and it fails as expected:
|
morozov
force-pushed
the
spatial-index-length
branch
from
March 3, 2021 02:19
74f661d
to
304a537
Compare
morozov
approved these changes
Mar 3, 2021
Thanks, @ottaviano. |
mdumoulin
pushed a commit
to mdumoulin/dbal
that referenced
this pull request
Mar 5, 2021
[Mysql] ignore index length for spatial indexes
hi @morozov, would you know if the new release 2.12.2 will be created soon? |
The plan is to release it right before 2.13.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Skips index length option for SPATIAL index on MySql (cf initial issue and this PR #3970 for more details)