Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mysql] ignore index length for spatial indexes #4525

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

ottaviano
Copy link
Contributor

@ottaviano ottaviano commented Mar 1, 2021

Q A
Type bug
BC Break no
Fixed issues #3561

Summary

Skips index length option for SPATIAL index on MySql (cf initial issue and this PR #3970 for more details)

@morozov
Copy link
Member

morozov commented Mar 3, 2021

@ottaviano, looks good. I just ran the new test w/o the fix, and it fails as expected:

$ phpunit -c mysqli.phpunit.xml --filter testSpatialIndex tests/Doctrine/Tests/DBAL/Functional/Schema/MySqlSchemaManagerTest.php
PHPUnit 9.5.0 by Sebastian Bergmann and contributors.

F                                                                                   1 / 1 (100%)

Time: 00:00.221, Memory: 16.00 MB

There was 1 failure:

1) Doctrine\Tests\DBAL\Functional\Schema\MySqlSchemaManagerTest::testSpatialIndex
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 (
-    0 => null
+    0 => 32
 )

/Users/smorozov/Projects/dbal/tests/Doctrine/Tests/DBAL/Functional/Schema/MySqlSchemaManagerTest.php:114

FAILURES!
Tests: 1, Assertions: 3, Failures: 1.

@morozov morozov force-pushed the spatial-index-length branch from 74f661d to 304a537 Compare March 3, 2021 02:19
@morozov morozov added this to the 2.12.2 milestone Mar 3, 2021
@morozov morozov merged commit 70ab840 into doctrine:2.12.x Mar 3, 2021
@morozov
Copy link
Member

morozov commented Mar 3, 2021

Thanks, @ottaviano.

@ottaviano
Copy link
Contributor Author

Thank you, @morozov for review and fast merge and @ksaveras for initialising the fix of this issue 👍

mdumoulin pushed a commit to mdumoulin/dbal that referenced this pull request Mar 5, 2021
[Mysql] ignore index length for spatial indexes
@ottaviano
Copy link
Contributor Author

hi @morozov, would you know if the new release 2.12.2 will be created soon?
we are waiting for it to make a big update 🚀

@morozov
Copy link
Member

morozov commented Mar 17, 2021

The plan is to release it right before 2.13.0.

@morozov morozov modified the milestones: 2.12.2, 2.13.0 Apr 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants