Remove incomplete details of QueryBuilder::setParameter($type) #4543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
reviewed
Mar 13, 2021
morozov
changed the title
|
@andrew-demb please squash and update the commit message (see the updated PR title). Also, please retarget against the oldest supported version where this is applicable. |
|
@morozov Done. Thank you for your suggestions. |
morozov
approved these changes
Mar 16, 2021
|
Thanks, @andrew-demb. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The argument description doesn't mention a more flexible way to configure binding parameter type - use a constant from
Doctrine\DBAL\Types\Types.PR proposes to mention this way of type configurationUPD: instead of mention all ways to configure parameter type, the description updated to the short form, which is consistent with a codebase