Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-4554] Deprecate all Statement::fetch* in favor of Result::fetch* #4555

Merged
merged 1 commit into from
Mar 28, 2021
Merged

[GH-4554] Deprecate all Statement::fetch* in favor of Result::fetch* #4555

merged 1 commit into from
Mar 28, 2021

Conversation

beberlei
Copy link
Member

Q A
Type deprecation
BC Break no
Fixed issues #4554

Summary

Deprecates all Statement::fetch* methods as they need to be called from Result that is returned from Statement::execute in DBAL 3.

@beberlei beberlei requested review from morozov and greg0ire March 27, 2021 22:02
@beberlei beberlei force-pushed the GH-4554-DeprecateStatementFetch branch from 5645683 to b8238c7 Compare March 27, 2021 22:11
@beberlei beberlei added this to the 2.13.0 milestone Mar 27, 2021
morozov
morozov previously approved these changes Mar 28, 2021
View reviewed changes
@morozov
Copy link
Member

morozov commented Mar 28, 2021

@beberlei please squash.

@beberlei beberlei force-pushed the GH-4554-DeprecateStatementFetch branch from ae60d11 to 6c367ff Compare March 28, 2021 16:20
@beberlei
Copy link
Member Author

@morozov done, wanted to make sure you saw the changes.

@beberlei beberlei merged commit 3125de1 into doctrine:2.13.x Mar 28, 2021
@beberlei beberlei deleted the GH-4554-DeprecateStatementFetch branch March 28, 2021 16:42
@beberlei beberlei mentioned this pull request Mar 28, 2021
Closed
@github-actions github-actions bot mentioned this pull request Mar 30, 2021
Merged
@gam6itko gam6itko mentioned this pull request Mar 31, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morozov morozov morozov approved these changes

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@beberlei @morozov