Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate TableGenerator #4681

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 18, 2021

Q A
Type improvement
BC Break no

I propose to deprecate and later remove the TableGenerator component for the following reasons:

  1. It doesn't seem to be used by open-source projects.
  2. It's one of the components that use Connection::getParams() which I'd like to get rid of eventually (Connection::getParams() leaks implementation details #3593).
  3. This code hasn't received any significant changes since its introduction in 2012 (468af75). This is either because it's perfect or because nobody uses it.

@greg0ire greg0ire added this to the 3.2.0 milestone Jun 19, 2021
@greg0ire greg0ire merged commit a90083a into doctrine:3.2.x Jun 19, 2021
@greg0ire
Copy link
Member

Thanks @morozov !

@morozov morozov deleted the deprecate-table-generator branch June 19, 2021 15:36
morozov added a commit to morozov/dbal that referenced this pull request Jun 26, 2021
morozov added a commit to morozov/dbal that referenced this pull request Jun 26, 2021
morozov added a commit that referenced this pull request Jun 26, 2021
@morozov morozov mentioned this pull request Jun 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants