Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #4739

Merged
merged 2 commits into from
Aug 1, 2021
Merged

Code cleanup #4739

merged 2 commits into from
Aug 1, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Jul 31, 2021

Q A
Type improvement
BC Break no
  1. Remove unnecessary property default values
  2. Remove unused local variables

The above issues have been identified using PhpStorm code inspection.

@morozov morozov marked this pull request as ready for review July 31, 2021 21:53
@morozov morozov requested a review from greg0ire July 31, 2021 21:57
@morozov morozov added this to the 3.1.2 milestone Jul 31, 2021
@morozov morozov merged commit e974d4d into doctrine:3.1.x Aug 1, 2021
@morozov morozov deleted the code-cleanup branch August 1, 2021 23:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SenseException SenseException SenseException approved these changes

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees
No one assigned
Labels
Static Analysis
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @SenseException