Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods being reworked are defined in the
AbstractPlatform
sub-classes but do not belong to the Platform API:OraclePlatform::assertValidIdentifier()
is not used anywhere. The DBAL is not the source of truth about the validity of a given identifier.OraclePlatform::getCreateAutoincrementSql()
is only called from within the class and should be made protected.OraclePlatform::getDropAutoincrementSql()
is only called from within the schema manager. There's definitely some asymmetry with the above method. We can decide on how to improve this API later. For instance, get rid of the triggers in favor of identity columns.SQLServerPlatform
methods in question are only called from within the class and should be made protected.