Fix version displayed in ConsoleRunner
#4825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
changed the title
ConsoleRunner
derrabus
force-pushed
the
bugfix/console-runner-version
branch
from
4447a5a to
b64fb4d
Compare
morozov
approved these changes
Sep 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When calling the
vendor/bin/doctrine-dbaltool, it displays the version of the root package. The root package is usually the application that uses DBAL as a dependency. For instance, if I call this script from thesymfony/symfonyrepository, it displays the Symfony version. I doubt that this is intended and assume that the DBAL version should be displayed instead. At least, this is the behavior on the 2.13.x branch where we still had aVersionclass for that purpose.This PR fixes this problem by hardcoding the package name.