Get view definition for SQL Server #4844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
reviewed
Oct 7, 2021
|
Given that the DBAL doesn't use views itself, I'd rather classify this as an improvement. In this case, the patch should target |
|
Hi @morozov , thank you for review. I will add tests for this. I am sorry, should I change the current PR base to |
Yes, this was the first step. Now you need to rebase your changes on $ git checkout fix-sqlserver-view
$ git rebase HEAD~ --onto 3.2.x # this assumes you want to rebase one commit
$ git push -f # adjust according to your remote naming |
kitloong
force-pushed
the
fix-sqlserver-view
branch
from
877213a to
d935c0f
Compare
kitloong
commented
Oct 11, 2021
|
Hello @morozov Following items completed.
Please review. |
morozov
reviewed
Oct 12, 2021
morozov
reviewed
Oct 12, 2021
morozov
reviewed
Oct 13, 2021
|
@kitloong looks good. Please squash again. |
derrabus
reviewed
Oct 13, 2021
Currently, SQLServer2012Platform::getListViewsSQL does not export view definition. This commit get view definition for SQL server. Reference: https://docs.microsoft.com/en-us/sql/relational-databases/views/get-information-about-a-view?view=sql-server-ver15#to-get-the-definition-and-properties-of-a-view
kitloong
force-pushed
the
fix-sqlserver-view
branch
from
e58dd7d to
537d889
Compare
morozov
approved these changes
Oct 14, 2021
|
Thanks, @kitloong! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently,
SQLServer2012Platform::getListViewsSQLdoes not export view definition.This PR updated the SQL so that
Doctrine\DBAL\Schema\View::getSql()will return view definition instead of empty string.