Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge AbstractPostgreSQLPlatformTestCase into PostgreSQLPlatformTest #4857

Merged
merged 1 commit into from
Oct 10, 2021
Merged

Merge AbstractPostgreSQLPlatformTestCase into PostgreSQLPlatformTest #4857

merged 1 commit into from
Oct 10, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Oct 10, 2021

PostgreSQLPlatformTest is the only class that extends AbstractPostgreSQLPlatformTestCase while neither references a PostgreSQL version. There's no need for two classes.

@morozov morozov added this to the 3.2.0 milestone Oct 10, 2021
@morozov morozov marked this pull request as ready for review October 10, 2021 05:53
@morozov morozov requested a review from greg0ire October 10, 2021 05:54
@morozov morozov merged commit 63e9241 into doctrine:3.2.x Oct 10, 2021
@morozov morozov deleted the merge-postgresql-tests branch October 10, 2021 13:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
PostgreSQL Test Suite
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @greg0ire