Remove redundant assert

[kamil-tekiela]

Signed-off-by: Kamil Tekiela tekiela246@gmail.com

Q	A
Type	improvement
BC Break	no
Fixed issues	Code cleanup

Summary

The function mysqli_init can only return false when the initialization fails. The initialization can only fail when there's not enough system memory, in which case this function returning false is the least of the problems. There's no reason to assert that this function didn't return false. If we want to avoid FP static analyser warnings then we can use the OO style (which I also think should be used to follow the coding style as I can't see any other mysqli function used in procedural style). This makes the code cleaner and easier to understand.

[morozov]

If we want to avoid FP static analyser warnings [...]

Yes, that was the primary reason to introduce this assertion (#4524). Thanks for the patch!

How come that being aliases, mysqli_init() does report the failure via the return values but new mysqli() doesn't? Will the latter throw an exception in case of an initialization failure?

[kamil-tekiela]

How come that being aliases, mysqli_init() does report the failure via the return values but new mysqli() doesn't?

I have wondered about the same and this bugs me a little, but I don't know if it's worth doing anything about it now. The procedural style is weird. It only returns objects on success. While it's extremely unlikely that mysqli_init() could ever return false this is the accepted style. If something would ever go wrong then this function will return false instead of an object. mysqli_connect() behaves similarly, but there exists a real possibility of it actually failing (when error reporting is silenced).

I don't know what would need to happen for mysqlnd to not be able to initialize the object properly. If mysqli is compiled with libmysqlclient then it's possible that the libmysqlclient cannot allocate memory and it will return NULL. I think this is the only possible way that mysqli_init() could return false.

Will the latter throw an exception in case of an initialization failure?

No, it will fail silently, but that should not be a huge problem. You can't use uninitialized mysqli object anyway. If you tried calling real_connect() on such object you would get an error:

mysqli object is already closed