Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete define() check #4925

Merged
merged 1 commit into from
Oct 24, 2021
Merged

Remove obsolete define() check #4925

merged 1 commit into from
Oct 24, 2021

Conversation

derrabus
Copy link
Member

Q A
Type improvement
BC Break no
Fixed issues N/A

Summary

The constant that is checked here should be present since PHP 5.6.

@derrabus derrabus added this to the 3.2.0 milestone Oct 23, 2021
@derrabus
Remove obsolete define() check
90a46c4 
Signed-off-by: Alexander M. Turek <me@derrabus.de>
@derrabus derrabus force-pushed the improvement/pgsql-remove-define branch from 25180c1 to 90a46c4 Compare October 23, 2021 23:24
@derrabus derrabus merged commit 7f0f3a3 into doctrine:3.2.x Oct 24, 2021
@derrabus derrabus deleted the improvement/pgsql-remove-define branch October 24, 2021 06:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morozov morozov morozov approved these changes

Assignees
No one assigned
Labels
Improvement pdo_pgsql
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@derrabus @morozov