Basic exception handling for SQL Server #4928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
sqlsrv-exception-handler
branch
from
9adeab1 to
41b6200
Compare
greg0ire
approved these changes
Oct 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestUtil::getConnectionParams()instead of$this->connection->getParams(). See Connection::getParams() leaks implementation details #3593.testConnectionException()test has been refactored into three since one of the scenarios is not fully supported by the SQL Server drivers. Once this test is enabled, we'll need to useLoginTimeout=1in the connection parameters. Otherwise, the connection may take 20-30 seconds to fail.