PHPStan 1.0.2

[derrabus]

Q	A
Type	improvement
BC Break	no
Fixed issues	N/A

Summary

I've bumped PHPStan to the new 1.0.0 and made the necessary adjustments.

I've also tried out the new level 9 and decided that we probably can live with level 8 on old branches. 😇

[ERROR] Found 742 errors

[derrabus]

@morozov This error seems to be raised because of the stub you contributed in phpstan/phpstan-src#700.

The mysqli_stmt::$affected_rows property is documented as int|string which is also what the documentation on php.net says. The documentation does not say in which cases we can expect a string here, but my guess is that this happens if the number of affected rows is larger than PHP_INT_MAX.

However, this also applies to mysqli_stmt::$num_rows which your stub documents as 0|positive-int.

[morozov]

So the stub probably should be 0|positive-int|string, as well as the return type in the DBAL driver.

[morozov]

I.e. we also need to change the @return annotation on (Statement|Result)::rowCount() from int to int|string because it will return a string if the value is greater than PHP_INT_MAX.

[derrabus]

This is a bit of a problem because on 3.1.x, we already have an int return type declaration.

[morozov]

I see. Then I think it's acceptable. Unlike the discussion in doctrine/orm#8963 (comment), updating or deleting a number of rows larger than PHP_INT_MAX is close to impossible.

[morozov]

So the stub probably should be 0|positive-int|string, as well as the return type in the DBAL driver.

[greg0ire]

Thanks @derrabus !