Accept driver-level statement as a wrapper-level statement constructor argument #4950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
previously approved these changes
Nov 6, 2021
morozov
force-pushed
the
statement-constructor-argument
branch
from
ed04838 to
9414d5d
Compare
derrabus
approved these changes
Nov 6, 2021
derrabus
approved these changes
Nov 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By calling
Connection::getWrappedConnection(), the wrapper statement breaks encapsulation of the connection. Instead, the wrapper connection should callprepare()on its wrapped connection and pass the result to the wrapper statement.