Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation annotation to SQLServer2012Platform #5061

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

derrabus
Copy link
Member

Q A
Type bug
BC Break yes/no
Fixed issues N/A

Summary

The class SQLServer2012Platform had been deprecated in 3.2 according to the upgrade documentation, but it was not flagged as @deprecated.

@@ -5,6 +5,8 @@
/**
* Provides the behavior, features and SQL dialect of the Microsoft SQL Server database platform
* of the oldest supported version.
*
* @deprecated Use {@see SQLServerPlatform} instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if {@see ...} also works but we usually use {@link ...} to reference code elements.

@derrabus derrabus merged commit 2279779 into doctrine:3.2.x Dec 1, 2021
@derrabus derrabus deleted the deprecate/sql-2012-platform branch December 1, 2021 15:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants