Clean up SQL generation in MySQL platform #5071
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified in #4978 (comment), the query generated by
getListTableForeignKeysSQL()
uses aDISTINCT
clause which requires selecting the columns used in theORDER BY
clause.What has been changed:
DISTINCT
clause has been removed since it's not necessary.WHERE k.REFERENCED_COLUMN_NAME IS NOT NULL
condition has been removed since it's not necessary.WHERE c.constraint_schema = $databaseNameSql
condition has been replaced with an analogousON
condition.Additionally, the following has been done in multiple queries:
DATABASE()
has been extracted into a private method.$string = quote($string)
have been replaced with inlining with the concatenation to avoid potential double quoting.The last two changes likely would have happened in #4882 but it's better to do the cleanup separately.