Honor requiresSQLCommentHint() for overriding types #5077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The side-effect of isCommentedDoctrineType() is preserved for backward-compatibility reasons.
greg0ire
force-pushed
the
ensure-comments-are-here
branch
from
f4a0a17 to
5dd30ad
Compare
Makes sense in general but what side effects the API consumers may rely on? Are you talking about the overridden implementation of |
morozov
approved these changes
Dec 2, 2021
The property being filled, for instance (it's protected so accessible by classes extending |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The side-effect of isCommentedDoctrineType() is preserved for
backward-compatibility reasons.
Fixes #4983