Add Postgres native identity column support #5257
Conversation
| return true; | ||
| return false; |
There was a problem hiding this comment.
I'm guessing that this isn't fine, and is a BC break?
There was a problem hiding this comment.
A BC break will happen when someone upgrades to the version of the DBAL that uses IDENTITY instead of sequences and has their sequence values reset. See #4744 (comment) for more details.
There was a problem hiding this comment.
Maybe this can be handled in the \Doctrine\DBAL\Schema\PostgreSqlSchemaManager, when we detect going from a non-native identity autoinc column, to a native one?
There was a problem hiding this comment.
I see two ways here:
- We do it in the schema manager as you suggested. This way, the upgrade process will be implemented in the library, so the change won't be breaking and could be accepted in a minor release.
- We do it via documentation and a separate upgrade tool. This way, it will be a breaking change.
Both approaches have their pros and cons. BTW, apparently, I prototyped the same thing back in August: 3.4.x...morozov:pgsql-identity.
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
|
Closing in favor of #5396. |
Summary