Inject EventManager when using a custom platform #5320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
reviewed
Mar 12, 2022
spideyfusion
force-pushed
the
fix-event-manager-for-custom-platform
branch
from
f41b9cb to
39f7bf0
Compare
spideyfusion
force-pushed
the
fix-event-manager-for-custom-platform
branch
from
39f7bf0 to
735ee90
Compare
morozov
approved these changes
Apr 15, 2022
|
Looks good to me. Thanks, @spideyfusion. |
SenseException
approved these changes
Apr 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fix ensures that schema-related events (e.g.
onSchemaAlterTable) get fired when aConnectionreceives aPlatforminstead of relying on auto-detection.