Add runtime deprecations for default string column length #5377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
morozov
force-pushed
the
default-string-length-runtime-deprecation
branch
from
5e165f3 to
05a2211
Compare
morozov
commented
May 5, 2022
| 'name' => $name, | ||
| 'version' => $column->hasPlatformOption('version') ? $column->getPlatformOption('version') : false, | ||
| 'comment' => $this->getColumnComment($column), | ||
| ]); | ||
|
|
||
| if ($columnData['type'] instanceof Types\StringType && $columnData['length'] === null) { | ||
| $columnData['length'] = $this->getVarcharDefaultLength(); |
There was a problem hiding this comment.
This is already implemented in getVarcharTypeDeclarationSQL():
dbal/src/Platforms/AbstractPlatform.php
Lines 208 to 210 in fade2e2
If this block is left as is, then it will be impossible to detect whether the column length was specified explicitly or the default value is used.
morozov
force-pushed
the
default-string-length-runtime-deprecation
branch
from
05a2211 to
185bdd3
Compare
derrabus
approved these changes
May 5, 2022
greg0ire
approved these changes
May 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.