Unset the default value if the given column definition is an integer …

[berrugo]

Unset the default value if the given column definition is an integer and the default value is a string

Q	A
Type	bug
Fixed issues	N/A

Summary

This is kinda of an edge case that I found when working with Laravel migrations. I wanted to change a column type from VARCHAR(32) DEFAULT '' to INT and got the following malformed SQL expression from Doctrine\DBAL\Platforms\AbstractMySQLPlatform\getAlterTableSQL()

"ALTER TABLE location_details CHANGE location_id location_id INT DEFAULT NOT NULL"

Since the column's original default value was a string, in this case an empty one '', it got carried over to the ALTER statement. The fix I propose is to check if the new column type is an PhpIntegerMappingType and if its default value a string then unset the default, similar to what we already do with TextType and BlobType. After this fix, the resulting SQL statement should be the following:

"ALTER TABLE location_details CHANGE location_id location_id INT NOT NULL"

[morozov]

This looks similar to #3714 and #3813 (which are also related to Laravel).

I don't believe that the DBAL should be in the business of silently dropping the default. If it's not important, it shouldn't have been set in the original column to an empty string in the first place.