Run Psalm with language level PHP 8.1 #5417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
May 31, 2022
|
Unlike the ORM, the PHPStan configuration for the DBAL doesn't specify a PHP version and I don't know what it defaults to. That's why I decided not to add it here. |
rgrellmann
added a commit
to Rossmann-IT/dbal
that referenced
this pull request
Jul 13, 2022
Release [3.3.7](https://github.com/doctrine/dbal/milestone/114) 3.3.7 ===== - Total issues resolved: **1** - Total pull requests resolved: **8** - Total contributors: **6** Code Style,Static Analysis -------------------------- - [5444: PHP CodeSniffer 3.7, PHPStan 1.7.13](doctrine#5444) thanks to @derrabus Static Analysis --------------- - [5426: PHPStan 1.7.9](doctrine#5426) thanks to @derrabus - [5417: Run Psalm with language level PHP 8.1](doctrine#5417) thanks to @morozov Documentation,Type Mapping -------------------------- - [5415: Update documentation for the `guid` type](doctrine#5415) thanks to @kaznovac Bug,PostgreSQL,Schema Management -------------------------------- - [5395: Check integer types via PhpIntegerMappingType](doctrine#5395) thanks to @morozov and @umherirrender Bug,PHP,PostgreSQL ------------------ - [5381: Fix using deprecated syntax](doctrine#5381) thanks to @nicolas-grekas Documentation ------------- - [5379: Refresh docs about transactions](doctrine#5379) thanks to @greg0ire CI -- - [5374: Remove CA bundle from AppVeyor](doctrine#5374) thanks to @morozov # gpg: Signature made Fri Jun 17 09:51:42 2022 # gpg: using DSA key 1BEDEE0A820BC30D858F9F0C2C3A645671828132 # gpg: Can't check signature: No public key
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static analysis builds recently started failing after the Symfony Console 6.1 release (example). It uses the PHP 8.1 syntax, it is compatible with the runtime PHP version which Composer uses to resolve the dependency constraints but Psalm assumes the PHP 7.3 syntax according to
composer.json.The ORM uses the same approach to configuring Psalm: doctrine/orm#9314.