Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ConsoleRunner #5439

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 9, 2022

The class serves two purposes:

  1. Helping users bootstrap a CLI application. The class is not extensible by any means, so if a user needs to modify the CLI application, they will have to copy the code from the DBAL to their project. It's better if they start by implementing the application from scratch using the documentation.
  2. Registering all DBAL-supplied commands in one call. The DBAL supplies a single non-deprecated command. Furthermore, the ORM doesn't use this class when registering DBAL commands, meaning that it's not that important.

See #5337 (review) for more details.

@morozov morozov added this to the 3.4.0 milestone Jun 9, 2022
@morozov morozov requested review from greg0ire and derrabus June 10, 2022 00:40
@derrabus
Copy link
Member

The documentation on how to set up the console needs to be updated if we don't want people to use ConsoleRunner anymore.

@morozov morozov force-pushed the deprecate-console-runner branch from 4548ee1 to 216c838 Compare June 10, 2022 02:14
@morozov morozov merged commit 7307ecc into doctrine:3.4.x Jun 10, 2022
@morozov morozov deleted the deprecate-console-runner branch June 10, 2022 13:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants