Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API is a legacy of PDO and was mostly supposed to be used in two cases:
dbal/tests/Functional/StatementTest.php
Lines 187 to 195 in bf648df
$length
in order to avoid truncation of string values (see the documentation onoci_bind_by_name()
for more details). I don’t see a reason why anyone would want to do that (e.g. the ORM doesn’t).Deprecating this API will simplify the improvements of type safety of the Statement API.
The only problem it may create is that
bindParam()
might be used to migrate to a better identity generation API in the ORM for Oracle (see #5443 (comment) for more details). It’s a low-priority/high-effort project, and I’m sure that if we ever get to it, we’ll find a better-localized solution.