Formally allow url in DriverManager::getConnection()
#5857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Jan 6, 2023
SenseException
approved these changes
Jan 6, 2023
derrabus
approved these changes
Jan 7, 2023
|
I'm quite impressed this little change deserved attention of three contributors :D |
|
I now own a contributor badge too, lmao. |
|
Thank you very much for taking care of this critical bug. This badge was well earned! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Psalm complains when instantiating a Connection like this:
DriverManager::getConnection([ 'url' => 'mysql://user:pwd@host/db' ]), becauseurlis not explicitly allowed in@psalm-paramphpdoc. Perhaps it was forgotten.