Middleware is uncountable #6033
Conversation
l-vo
force-pushed
the
middleware_is_uncountable
branch
from
419160b to
89e0ee7
Compare
l-vo
force-pushed
the
middleware_is_uncountable
branch
from
89e0ee7 to
d9d87c3
Compare
|
@derrabus updated. |
| Middlewares | ||
| ----------- | ||
| Middleware | ||
| ---------- | ||
|
|
||
| A middleware sits in the middle between the wrapper components and the driver. |
There was a problem hiding this comment.
If middleware is not countable, is there something like a middleware? The way you use the term in the Configuration class now, middleware is the whole layer between the driver an the wrapper. I think, we need to find a different term for the thing that we create through implementing the Middleware interface.
|
Regarding the deprecation, I'm really wondering if it's worth it. While the current method naming pattern Maybe it's enough to adjust the documentation only and keep the method names as they are? Paging @morozov as he's the main author of the middleware system. |
|
@derrabus I'm agree, but even if it's not a good Idea, this PR will keep a trace of this discussion 👍 |
|
I don't think this change provides any value while at the same it clearly causes damage. The definition from the dictionary focuses on the middleware being a layer (a collective notion) while in this specific design, middleware is an interface and its specific implementations, so they are countable. The existing code operates both the specific instances of middleware and their collections, so using the same single tense for both might become confusing and impractical at some point. Natural languages evolve and adjust to their actual usage, they are not set in stone. Here are the examples of using "middlewares" in the open-source code. |
|
@morozov it makes sense, thank you for your feedback 👌 |
Summary
According to https://www.oxfordlearnersdictionaries.com/definition/english/middleware, middleware is uncountable.