bug fix: keep length of -1 for nvarchar(max) columns in SqlServerSchemaManager #6039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a note on https://github.com/doctrine/dbal/blob/3.6.x/docs/en/reference/query-builder.rst to say that the QueryBuilder uses a needle of 0. This edit adds a similar note to this document.
Note on bindValue positional needle
Gender Neutral Language
MaximilianSpeer
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When generating the portable table column definition for a nchar, nvarchar or ntext with a length of -1 (indicating MAX) the length remains -1 instead of getting divided. This lead to a wrong length of -1.