Add Type::lookupName() shortcut method #6130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
type_lookupname
branch
from
3c0f0a6 to
b1e609e
Compare
mvorisek
changed the title
|
LGTM. The
I don't think we should do that. The current name is fine. |
derrabus
approved these changes
Aug 22, 2023
cgknx
pushed a commit
to cgknx/dbal
that referenced
this pull request
Aug 30, 2023
| Q | A |------------- | ----------- | Type | feature | Fixed issues | n/a #### Summary `Type` class has static methods for global `TypeRegistry` instance shorter access like `Type::getType`. This feature adds a static method for `TypeRegistry::lookupName`. Thanks to doctrine#6082, the reverse lookup is O(1) thus fine to be used massively - for ex. schema introspection returns type as object, and this method is needed to obtain a string name. In DBAL 4.0, the method can be renamed to `Type::getName(Type $type): string` to be more consistent with `Type::getType(string $name): Type`.
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Typeclass has static methods for globalTypeRegistryinstance shorter access likeType::getType.This feature adds a static method for
TypeRegistry::lookupName.Thanks to #6082, the reverse lookup is O(1) thus fine to be used massively - for ex. schema introspection returns type as object, and this method is needed to obtain a string name.
In DBAL 4.0, the method can be renamed to
Type::getName(Type $type): stringto be more consistent withType::getType(string $name): Type.