Fix pg boolean conversion #625

lucasvanlierop · 2014-06-26T19:09:22Z

Merge of complementary PR's #527 and #564 + some fixes. Contributing it as an result of the (extended) phpconference.nl 2014 hackathon.

stof · 2014-06-26T22:49:28Z

This branch needs to be rebased as it conflicts with master (and changes shpoould probably be squashed a bit)

Ocramius · 2014-06-27T08:30:39Z

@lucasvanlierop thanks for taking care of this. Maybe I can catch you during the conference and we can discuss the PR together :-)

lucasvanlierop · 2014-06-27T08:43:27Z

@stof, PR is now up to date with master, I will squash the whole thing when it's finished.

@Ocramius, yes good idea, currently I'm at the point where I think boolean conversion deserves it's own class instead of having lots of extra methods in de platform class. But I don't know if you like that idea? Maybe we can use part of the lunch break to discuss it?

Ocramius · 2014-06-27T12:53:35Z

lib/Doctrine/DBAL/Platforms/AbstractPlatform.php

+     *
+     * @param mixed $item
+     *
+     * @return bool


bool|null

Ocramius · 2014-06-27T13:43:26Z

lib/Doctrine/DBAL/Platforms/AbstractPlatform.php

     *
+     * @param  mixed $item


as discussed, more precise types here

Same here, I would like to do it but not possible.

lucasvanlierop · 2014-06-29T17:50:12Z

@davividal and @birko I've merged both your PR's (#564 and #527) into one new PR handling both the conversion from Postgresql database boolean values to php and vice versa. Please check if it still is what you meant it to be. I'm just here to help out with longstanding open PR's.

@deeky666, Would you review this as you commented on the original PR's and also suggested part code @davividal has contributed.

deeky666 · 2014-06-30T10:27:16Z

At the first glance this PR looks good so far. Something that we didn't talk about here is possible performance implications. I talked about this issue with @beberlei some time ago and he wasn't happy with all those callbacks. But I don't know really know if that has any impact on performance.
Otherwise I would like to hear from the originals authors again if they are fine with it and afterwards merge?

lucasvanlierop · 2014-06-30T10:45:15Z

@deeky666, thanks for taking a look. Well to be honest the conversion feels a bit over engineered to me but I tried to keep the focus on merging complementary solutions (and some cleaning up) and so I kept the logic more or less like it was.

deeky666 · 2014-06-30T12:16:38Z

The original implementation had a lot of code duplication and was rather hard to read and understand. Thus I proposed a more "simplified" solution with smaller methods removing the code duplication but I see and understand that those callbacks are rather heavy here. TBH I don't mind which way to go :)
Thanks for putting both PRs together btw.

davividal · 2014-06-30T13:27:12Z

Looks fine for me.

I don't know how to test performance of the callback implementation, sorry.

birko · 2014-06-30T13:36:18Z

Hmm for me probably ok. If I am looking correctly

Ocramius · 2014-06-30T13:37:31Z

@lucasvanlierop can you please remove lucasvanlierop/dbal@15d876f ? Please rebase instead.

Default Boolean conversion behaviour

added postgresql literals to Boolean conversion

Changed to call platform specific Boolean conversion

added postgresql platform conversion test

fixed bug when $item was set as bool true value added 'off' literal

added literals off and on to the testcase

Changes after Ocramius comments

fixed parameter order in conditions

Description fix

…o 2.4

edigu · 2014-10-27T16:44:08Z

This problem still continues in PHP 5.6. I think it needs more specific test. See #632

Ocramius · 2014-11-05T17:38:34Z

Probably related to #714

mbeccati · 2014-11-06T16:07:56Z

Possibly caused by https://bugs.php.net/bug.php?id=68351 - which I've just fixed (sorry I haven't read the full thread here ;) )

deeky666 · 2014-11-07T08:27:38Z

@mbeccati this reads promising. Does it also apply to \PDOStatement::bindValue()? Could you maybe add a test for null values? Because this is what's going wrong here. Inserting a null value into a nullable boolean column with emulated prepares enabled and using \PDOStatement::bindValue(1, null, \PDO::PARAM_BOOL) result in PHP converting null to true in PHP 5.6 while it was converted to false in PHP < 5.6.

mbeccati · 2014-11-07T09:59:47Z

@deeky666 yes, that's precisely what the fix is for. The bug existed in previous versions as well, but it was probably less likely to trigger it.

deeky666 · 2014-11-07T13:46:25Z

@mbeccati awesome! Thanks a lot for taking care of that issue. It has been causing us bad headaches for some time now...

stof · 2014-11-13T11:12:24Z

lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php

+    private function convertSingleBooleanValue($value, $callback)
+    {
+        if (null === $value) {
+            return $callback(false);


you should use call_user_func to support all callables on PHP 5.3

hmm, given it is a private method, it may not be needed though

Maybe type-hint Closure?

edigu · 2014-12-22T07:47:16Z

@mbeccati The PDO::PARAM_BOOL and ATTR_EMULATE_PREPARES misbehaving bug is fixed in 5.6.4 and 5.5.20. See: https://bugs.php.net/bug.php?id=68351

Ocramius · 2014-12-22T08:50:00Z

@edigu awesome! :-)

@deeky666 do you think we should make DBAL conflict with >=5.6.0,<=5.6.3?

mbeccati · 2014-12-22T09:17:45Z

@Ocramius @deeky666 For reference, the PHP bug I fixed was there since https://bugs.php.net/bug.php?id=62593 was fixed - i.e. 5.4.9+ / 5.3.19+. I'm not even sure what was the behaviour before that.

stof · 2014-12-26T18:49:21Z

@Ocramius I don't think we should:

we don't exclude all PHP versions affected by a bug, otherwise people will just be unable to install the package in many cases. Doing it for a single bug would be inconsistent
it only affects the PostgreSQL driver, so why forbidding to use 5.6.0 for people using MySQL ?

Ocramius · 2014-12-26T18:51:24Z

why forbidding to use 5.6.0 for people using MySQL ?

Because of unforseen consequences there ("wtf" moments for pgsql users, mysql is fine). Anyway, users are still free to upgrade, and I agree with you on the users that are not affected by the bug.

I guess the only required change is a travis upgrade of PHP 5.6 (once available)

deeky666 · 2014-12-26T19:21:39Z

We could just document this incompatibility somewhere. Otherwise the only solution I see is to make PDO_PGSQL not use emulated prepares for those versions to stay compatible. But that would also require adjusting the PDO implementation DBAL wise....

PowerKiKi · 2014-12-29T01:28:08Z

Just to confirm that upgrading PHP from 5.6.3 to 5.6.4 indeed solved that bug for me without any other changes.

Also I agree with @deeky666 that it should be documented somewhere as known bugs.

deeky666 · 2014-12-29T02:36:41Z

I'd say let's wait for travis to go for 5.6.4, see the build result and then add a section in the documentation. Not going too complicated here, we cannot deal with everything....

Vincent-Simonin · 2015-02-27T10:24:08Z

Hello,
Since DBAL v2.4.3 we can't handle null value on boolean field : false is returned instead of null.
Is this normal ?

edigu · 2015-02-27T10:37:55Z

@Vincent-Simonin what is your php version?

Vincent-Simonin · 2015-02-27T11:17:09Z

@edigu v5.5.22

lucasvanlierop changed the title ~~Fix pg boolean conversion~~ [WIP] Fix pg boolean conversion Jun 26, 2014

Ocramius reviewed Jun 27, 2014
View reviewed changes

Ocramius mentioned this pull request Jun 27, 2014

[DBAL-630] Incorrect PostgreSQL boolean handling #564

Closed

Ocramius reviewed Jun 27, 2014
View reviewed changes

lucasvanlierop changed the title ~~[WIP] Fix pg boolean conversion~~ Fix pg boolean conversion Jun 29, 2014

birko added 10 commits June 30, 2014 15:44

Update AbstractPlatform.php

1c562fc

Default Boolean conversion behaviour

Update PostgreSqlPlatform.php

47e0370

added postgresql literals to Boolean conversion

Update BooleanType.php

1ae0bd8

Changed to call platform specific Boolean conversion

Update AbstractPostgreSqlPlatformTestCase.php

d4becf6

added postgresql platform conversion test

Update PostgreSqlPlatform.php

46241ad

fixed bug when $item was set as bool true value added 'off' literal

Update AbstractPostgreSqlPlatformTestCase.php

4dfc8f1

added literals off and on to the testcase

Update PostgreSqlPlatform.php

402c7c8

Changes after Ocramius comments

Update PostgreSqlPlatform.php

ee87790

fixed parameter order in conditions

Update AbstractPlatform.php

d901ba2

Description fix

Update PostgreSqlPlatform.php

7b161fa

Ocramius added a commit that referenced this pull request Jul 29, 2014

#625 - fixed phpunit runner path for travis

339aa79

Ocramius added a commit that referenced this pull request Jul 29, 2014

Merge branch 'hotfix/#636-backport-#625-pgsql-boolean-conversion' int…

11fd2c9

…o 2.4

stof reviewed Nov 13, 2014
View reviewed changes

Ocramius mentioned this pull request Nov 27, 2014

Fix BooleanHandler for PostgreSQL wmde/WikibaseQueryEngine#140

Merged

Ocramius mentioned this pull request Mar 2, 2015

PDO, PostgreSQL and bool zendframework/zendframework#7284

Closed

GeeH mentioned this pull request Jun 28, 2016

PDO, PostgreSQL and bool zendframework/zend-db#134

Open

michalbundyra mentioned this pull request Jan 16, 2020

PDO, PostgreSQL and bool laminas/laminas-db#114

Closed

github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix pg boolean conversion #625

Fix pg boolean conversion #625

lucasvanlierop commented Jun 26, 2014

stof commented Jun 26, 2014

Ocramius commented Jun 27, 2014

lucasvanlierop commented Jun 27, 2014

Ocramius Jun 27, 2014

lucasvanlierop Jun 27, 2014

Ocramius Jun 27, 2014

lucasvanlierop Jun 29, 2014

lucasvanlierop commented Jun 29, 2014

deeky666 commented Jun 30, 2014

lucasvanlierop commented Jun 30, 2014

deeky666 commented Jun 30, 2014

davividal commented Jun 30, 2014

birko commented Jun 30, 2014

Ocramius commented Jun 30, 2014

edigu commented Oct 27, 2014

Ocramius commented Nov 5, 2014

mbeccati commented Nov 6, 2014

deeky666 commented Nov 7, 2014

mbeccati commented Nov 7, 2014

deeky666 commented Nov 7, 2014

stof Nov 13, 2014

stof Nov 13, 2014

Ocramius Nov 13, 2014

edigu commented Dec 22, 2014

Ocramius commented Dec 22, 2014

mbeccati commented Dec 22, 2014

stof commented Dec 26, 2014

Ocramius commented Dec 26, 2014

deeky666 commented Dec 26, 2014

PowerKiKi commented Dec 29, 2014

deeky666 commented Dec 29, 2014

Vincent-Simonin commented Feb 27, 2015

edigu commented Feb 27, 2015

Vincent-Simonin commented Feb 27, 2015

Fix pg boolean conversion #625

Fix pg boolean conversion #625

Conversation

lucasvanlierop commented Jun 26, 2014

stof commented Jun 26, 2014

Ocramius commented Jun 27, 2014

lucasvanlierop commented Jun 27, 2014

Ocramius Jun 27, 2014

Choose a reason for hiding this comment

lucasvanlierop Jun 27, 2014

Choose a reason for hiding this comment

Ocramius Jun 27, 2014

Choose a reason for hiding this comment

lucasvanlierop Jun 29, 2014

Choose a reason for hiding this comment

lucasvanlierop commented Jun 29, 2014

deeky666 commented Jun 30, 2014

lucasvanlierop commented Jun 30, 2014

deeky666 commented Jun 30, 2014

davividal commented Jun 30, 2014

birko commented Jun 30, 2014

Ocramius commented Jun 30, 2014

edigu commented Oct 27, 2014

Ocramius commented Nov 5, 2014

mbeccati commented Nov 6, 2014

deeky666 commented Nov 7, 2014

mbeccati commented Nov 7, 2014

deeky666 commented Nov 7, 2014

stof Nov 13, 2014

Choose a reason for hiding this comment

stof Nov 13, 2014

Choose a reason for hiding this comment

Ocramius Nov 13, 2014

Choose a reason for hiding this comment

edigu commented Dec 22, 2014

Ocramius commented Dec 22, 2014

mbeccati commented Dec 22, 2014

stof commented Dec 26, 2014

Ocramius commented Dec 26, 2014

deeky666 commented Dec 26, 2014

PowerKiKi commented Dec 29, 2014

deeky666 commented Dec 29, 2014

Vincent-Simonin commented Feb 27, 2015

edigu commented Feb 27, 2015

Vincent-Simonin commented Feb 27, 2015