PHPUnit 10.5.9 #6266
PHPUnit 10.5.9 #6266
Conversation
derrabus
force-pushed
the
bump/phpunit
branch
from
eb5f1f4 to
8147911
Compare
derrabus
force-pushed
the
bump/phpunit
branch
from
10d4569 to
918db1a
Compare
derrabus
force-pushed
the
bump/phpunit
branch
from
43cff1c to
0a3f35e
Compare
|
The AppVeyor failure is unrelated and will be resolved once 3.8.x is merged up. |
| @@ -84,7 +84,7 @@ jobs: | |||
| if: "${{ matrix.extension == 'sqlite3' }}" | |||
|
|
|||
| - name: "Run PHPUnit" | |||
| run: "vendor/bin/phpunit -c ci/github/phpunit/${{ matrix.extension }}.xml --coverage-clover=coverage.xml" | |||
| run: "vendor/bin/phpunit -c ci/github/phpunit/${{ matrix.extension }}.xml --coverage-clover=coverage.xml --display-warnings" | |||
There was a problem hiding this comment.
Is this equivalent to setting displayDetailsOnTestsThatTriggerNotices to true in our configuration files? I'm asking because if it is, then we might want to do that inside phpunit.xml so that there isn't a situation where contributors start to think they need to push to Github to get details about a warning. Also, I'm noticing that similar settings exist for notices, errors and deprecations. Shouldn't we turn them on as well?
There was a problem hiding this comment.
I don't know. I could also revert the commit that adds this option. I needed it to debug the warnings, but they're fixed now.
There was a problem hiding this comment.
Dropping that commit sounds good as well 👍
We can think about configuration more globally in a separate issue.
derrabus
force-pushed
the
bump/phpunit
branch
from
0a3f35e to
8e59ba6
Compare
This PR upgrades PHPUnit to 10.5.9.
Apparently, the build is broken by a couple of warnings that PHPUnit collected. I've pushed a commit that makes them visible. We should investigate those warnings.Warnings have been addressed.