Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SmallFloat type #6471

Merged
merged 9 commits into from
Jul 22, 2024
Merged

Add SmallFloat type #6471

merged 9 commits into from
Jul 22, 2024

Conversation

berkut1
Copy link
Contributor

@berkut1 berkut1 commented Jul 16, 2024

Q A
Type feature

Summary

Recreated PR #6467 for branch 4.1.

This PR adds support for the REAL type for all DBMS, thereby resolving issues with partial support and potential bugs related to the REAL type in SQL schemas during migration creation. I've tried to explain this issue in detail through the INET type here #6466.

Checked DBMS:

  • PostgreSQL (represents REAL as float4 or real)
  • MySQL/MariaDB (Feature: Add Real/Float4 type #6467 (comment))
  • MSSQL (represents REAL as real)
  • Oracle (represents REAL as float(63)) doc
  • IBM DB2 (represents REAL as real)
  • SQLite (represents REAL as real)

@berkut1
Copy link
Contributor Author

berkut1 commented Jul 16, 2024

I don't understand why it says that the test doesn't cover case 'float' for Oracle when it should.

tests/Types/RealFloatTest.php Outdated Show resolved Hide resolved
tests/Functional/Schema/OracleSchemaManagerTest.php Outdated Show resolved Hide resolved
@derrabus
Copy link
Member

I don't understand why it says that the test doesn't cover case 'float' for Oracle when it should.

CodeCov produces false positives at the moment when the upload of the coverage report fails.

@berkut1
Copy link
Contributor Author

berkut1 commented Jul 18, 2024

I guess need to re-run Github actions.

@berkut1 berkut1 changed the title feat: Add Real/Float4 type feat: Add Real/SmallFloat type Jul 20, 2024
@derrabus derrabus changed the title feat: Add Real/SmallFloat type Add Real/SmallFloat type Jul 21, 2024
docs/en/reference/types.rst Outdated Show resolved Hide resolved
tests/Types/SmallFloatTest.php Outdated Show resolved Hide resolved
tests/Types/SmallFloatTest.php Outdated Show resolved Hide resolved
@derrabus derrabus added this to the 4.1.0 milestone Jul 22, 2024
@derrabus derrabus changed the title Add Real/SmallFloat type Add SmallFloat type Jul 22, 2024
@derrabus derrabus merged commit 6ebcb77 into doctrine:4.1.x Jul 22, 2024
76 of 77 checks passed
@derrabus
Copy link
Member

Thank you!

derrabus added a commit to derrabus/dbal that referenced this pull request Jul 23, 2024
* 4.1.x:
  Properly handle MySQL error code 4031 from PHP 8.4 (doctrine#6363)
  Add SmallFloat type (doctrine#6471)
  CI: Add MySQL 9, reduce test matrix (doctrine#6462)
  Fix update/delete aliases in documentation (doctrine#6470)
  Complete sentence
  Docs: update custom platform example to use middlewares (doctrine#6460)
  ci: nightly - php-8.1 only + workflow_dispatch
  ci: nightly - php-8.1 min version (doctrine#6457)
  mariadb: add nightly workflow to facilitate mariadb "nightlies" (doctrine#6435)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants