-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SmallFloat type #6471
Merged
Merged
Add SmallFloat type #6471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't understand why it says that the test doesn't cover |
derrabus
reviewed
Jul 16, 2024
CodeCov produces false positives at the moment when the upload of the coverage report fails. |
I guess need to re-run Github actions. |
mvorisek
reviewed
Jul 19, 2024
derrabus
requested changes
Jul 21, 2024
derrabus
approved these changes
Jul 22, 2024
Thank you! |
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jul 23, 2024
* 4.1.x: Properly handle MySQL error code 4031 from PHP 8.4 (doctrine#6363) Add SmallFloat type (doctrine#6471) CI: Add MySQL 9, reduce test matrix (doctrine#6462) Fix update/delete aliases in documentation (doctrine#6470) Complete sentence Docs: update custom platform example to use middlewares (doctrine#6460) ci: nightly - php-8.1 only + workflow_dispatch ci: nightly - php-8.1 min version (doctrine#6457) mariadb: add nightly workflow to facilitate mariadb "nightlies" (doctrine#6435)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recreated PR #6467 for branch 4.1.
This PR adds support for the
REAL
type for all DBMS, thereby resolving issues with partial support and potential bugs related to theREAL
type in SQL schemas during migration creation. I've tried to explain this issue in detail through theINET
type here #6466.Checked DBMS:
REAL
asfloat4
orreal
)REAL
asreal
)REAL
asfloat(63)
) docREAL
asreal
)REAL
asreal
)