PDO: Raise a proper exception if user or password is false #6513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
changed the title
derrabus
force-pushed
the
bugfix/user-is-false
branch
from
0f38b9a to
7773849
Compare
greg0ire
previously approved these changes
Aug 30, 2024
morozov
reviewed
Aug 30, 2024
| public static function notAStringOrNull(string $key, mixed $value): self | ||
| { | ||
| return new self(sprintf( | ||
| 'The %s configuration setting is expected to be either a string or null, got %s.', |
There was a problem hiding this comment.
I'd use "configuration parameter" instead of "configuration setting" for consistency with the existing terminology. We use "params" / "parameters" a lot at least in the code.
There was a problem hiding this comment.
Thank you. I've adjusted the wording.
derrabus
force-pushed
the
bugfix/user-is-false
branch
from
7773849 to
3357e98
Compare
derrabus
force-pushed
the
bugfix/user-is-false
branch
from
3357e98 to
4363ac6
Compare
morozov
approved these changes
Sep 2, 2024
derrabus
added a commit
that referenced
this pull request
Sep 3, 2024
* 4.1.x: PDO: Raise a proper exception if user or password is false (#6513)
derrabus
added a commit
that referenced
this pull request
Sep 3, 2024
* 4.2.x: PDO: Raise a proper exception if user or password is false (#6513)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If
false(or anything that is not a string) is passed asuserorpassword, we run into aTypeErrorbecause we pass that value as-is to the constructor of PDO. This started to happen after we enabled strict types on our driver classes in 4.0.On 3.9,
falsewould implicitly be cast to an empty string which is either desired or leads to more obscure connection errors. We could restore the behavior of 3.9 by adding explicit type casts to the two parameters. But since we don't documentfalseas a valid value for either parameter, my preference would indeed be raising an exception.