Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close() method in MasterSlaveConnection.php #652

Merged
merged 1 commit into from Aug 4, 2014
Merged

Add close() method in MasterSlaveConnection.php #652

merged 1 commit into from Aug 4, 2014

Conversation

ghost
Copy link

@ghost ghost commented Aug 4, 2014

MasterSlaveConnection would use parent::close() to close connection, and it would close master connection, but slave connection.

That will increase the sqlite connections, and occur the "too many open files" error when I run our test.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. However did not open it on the "master"
branch. Our Git workflow requires all pull requests to go through "master" branch
and the release masters then merge them back into stable branches, if they are
bug fixes.

Please open the pull request again for the "master" branch and close
this one.

Nevertheless I have opened a Jira ticket for this Pull Request to track this
issue:

http://www.doctrine-project.org/jira/browse/DBAL-963

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius
Copy link
Member

Ocramius commented Aug 4, 2014

@accdavid does that also happen when you remove all references to the MasterSlaveConnection? This looks like a GC issue

@deeky666
Copy link
Member

deeky666 commented Aug 4, 2014

@Ocramius this is a backport. It is already implemented like this in master. So I don't see any problems with merging this.

@Ocramius
Copy link
Member

Ocramius commented Aug 4, 2014

@deeky666 excellent. Merging

Ocramius added a commit that referenced this pull request Aug 4, 2014
Add close() method in MasterSlaveConnection.php
@Ocramius Ocramius merged commit 1b62e9f into doctrine:2.4 Aug 4, 2014
@Ocramius Ocramius assigned Ocramius and unassigned deeky666 Aug 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants