Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect transactional() handling when DB auto-rolled back the transaction (v4) #6546

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Oct 12, 2024

This is how #6545 looks like for v4

… transaction

Let's get rid of There's no active transaction exception which occurs e.g. when using deferred constraints so the violation is checked at the end of the transaction and not during it.

- Do not rollback only on exceptions where we know the transaction is no longer active
- Introduce TransactionRolledBack exception
- Transform Oracle's "transaction rolled back" exception and use the underlying one that DBAL supports
@simPod
Copy link
Contributor Author

simPod commented Nov 5, 2024

@greg0ire I've adapted #6545 for v4

@simPod simPod marked this pull request as ready for review November 5, 2024 13:14
@greg0ire greg0ire added this to the 4.2.2 milestone Nov 5, 2024
@greg0ire greg0ire merged commit 5ddafce into doctrine:4.2.x Nov 5, 2024
91 checks passed
@simPod simPod changed the title Fix incorrect handling of transactions when using deferred constraints (v4) Fix incorrect transactional() handling when DB auto-rolled back the transaction (v4) Nov 11, 2024
@simPod simPod changed the title Fix incorrect transactional() handling when DB auto-rolled back the transaction (v4) Fix incorrect transactional() handling when DB auto-rolled back the transaction (v4) Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants