Rework handling quoted object names and reserved SQL keywords #6589
+526
−2,426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
name-parser
branch
4 times, most recently
from
5a3fa90
to
5723efa
Compare
sp_rename accepts the old name as a qualified name but the new name as a literal value. The caller of the stored procedure should be able to qualify the old name in order to reference a column in some table or a table in some schema, etc. But it's not necessary for the new name because the reference to the object being renamed is already established in the old name.
The pattern used in parseTableCommentFromSQL() was invalid. It would wrap the value returned by quoteSingleIdentifier() in another set of quotes. It would only work for unquoted table names, which would be handled but the pattern that matches an unquoted name. Before we enforce quoting of all table names, we need to fix the pattern.
The SQL being used by a component is an implementation detail. It should be tested in unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an early draft of an attempt to rework handling quoted object names and eliminate the need to maintain platform-specific keywords in the library.
It will partially fix #4357.