Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Identifier::toSql() to Identifier::toSQL() #6714

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Rename Identifier::toSql() to Identifier::toSQL() #6714

merged 1 commit into from
Jan 14, 2025

Conversation

morozov
Copy link
Member

@morozov morozov commented Jan 14, 2025

The original name wasn't intentional. toSQL() is consistent with the most of other method names ending with "SQL", especially Name::toSQL(), which the Identifier class backs.

@morozov morozov added this to the 4.3.0 milestone Jan 14, 2025
@morozov morozov merged commit bc38074 into doctrine:4.3.x Jan 14, 2025
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Schema Management
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@morozov @greg0ire