[DBAL-1028] Fix fetching NULL values via fetchColumn() #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1028 We use Jira to track the state of pull requests and the versions they got |
| } | ||
|
|
||
| return false; | ||
| return isset($row[$columnIndex]) || array_key_exists($columnIndex, $row) ? $row[$columnIndex] : null; |
There was a problem hiding this comment.
You can actually skip array_key_exists() here, as the return value will be null anyway
Ocramius
added a commit
that referenced
this pull request
Nov 5, 2014
[DBAL-1028] Fix fetching NULL values via fetchColumn()
This was referenced Dec 6, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PDOdrivers returnnullwhen retrieving a SQLNULLvalue from a column viaStatement::fetchColumn().However all native driver implementations except
mysqlireturnfalsewhich according to the interface should only be returned if no more rows are available or an error occurred. So currently it is not possible to retrieve a SQLNULLvalue viaStatement::fetchColumn()with those drivers.This PR fixes this. Additionally if a non-existing column index is requested from the resultset,
PDOalso returnsnullwhereas those mentioned native drivers returnfalse. This is also fixed.