-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Remove PHP 5.3 support #765
Conversation
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1103 We use Jira to track the state of pull requests and the versions they got |
👍 will take some time anyways until 2.6 will be released so I'm fine with it. |
Dropping it just for the matter of dropping it is not worth it IMO. This is useless if it does not allow to clean the codebase |
@stof this has actually a lot of avantages for us, even though we won't change the codebase in one shot (mainly to avoid merge conflicts). @deeky666 is setting up a complex CI environment for internal use by the doctrine org, and 5.3.x is very problematic to deal with. Yes, that was an excuse to drop it, but there's also no good excuse to keep supporting 5.3.x. Considering the current PHP 5.4 lifetime, we will also be able to introduce generator usage by the end of the year by dropping 5.4 support in DBAL 2.7 or such. |
This can be closed as #880 has been merged. |
Implemented in #2419 |
Just a suggestion for master (2.6). We should move on.