Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove PHP 5.3 support #765

Closed
wants to merge 3 commits into from

Conversation

Ocramius
Copy link
Member

@Ocramius Ocramius commented Jan 3, 2015

Just a suggestion for master (2.6). We should move on.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-1103

We use Jira to track the state of pull requests and the versions they got
included in.

@deeky666
Copy link
Member

deeky666 commented Jan 3, 2015

👍 will take some time anyways until 2.6 will be released so I'm fine with it.

@Ocramius Ocramius changed the title Remove PHP 5.3 support [WIP] Remove PHP 5.3 support Jan 3, 2015
@stof
Copy link
Member

stof commented Jan 17, 2015

Dropping it just for the matter of dropping it is not worth it IMO. This is useless if it does not allow to clean the codebase

@Ocramius
Copy link
Member Author

@stof this has actually a lot of avantages for us, even though we won't change the codebase in one shot (mainly to avoid merge conflicts).

@deeky666 is setting up a complex CI environment for internal use by the doctrine org, and 5.3.x is very problematic to deal with.

Yes, that was an excuse to drop it, but there's also no good excuse to keep supporting 5.3.x.

Considering the current PHP 5.4 lifetime, we will also be able to introduce generator usage by the end of the year by dropping 5.4 support in DBAL 2.7 or such.

@Tobion
Copy link
Contributor

Tobion commented Nov 15, 2015

This can be closed as #880 has been merged.

@deeky666
Copy link
Member

Implemented in #2419

@deeky666 deeky666 closed this Jul 15, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants