fix incorrect ordering of columns in clustered indexes on sql server #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when hydrated from schema info
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1186 We use Jira to track the state of pull requests and the versions they got |
|
@zeroedin-bill can you please provide a failing test case here plox? \m/ thanks |
|
@deeky666 test shows the bug with the old query, should be good to go now. All hail sql server... |
| $table = new Table('sqlsrv_pk_ordering'); | ||
| $table->addColumn('colA', 'integer', array('notnull' => true)); | ||
| $table->addColumn('colB', 'integer', array('notnull' => true)); | ||
| $table->setPrimaryKey(['colB', 'colA']); |
There was a problem hiding this comment.
You can't use short array syntax here as we are still on PHP 5.3
Can't use short array in php < 5.4
|
@deeky666 Fixed, thanks :) |
deeky666
added a commit
that referenced
this pull request
Apr 15, 2015
fix incorrect ordering of columns in clustered indexes on sql server
|
Thanks @zeroedin-bill ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When schema information is fetched from SQL server, the getListTableIndexesSQL was fetching index columns ordered by sys.index_columns.index_column_id. This was incorrect, because that column is simply a unique id for the column within the index. The column ordering information is actually in the key_ordinal column.
This PR changes SQLServerPlatform to generate a resultset ordered by key_ordinal instead of index_column_id.
This was causing schema diffs on tables with composite primary keys to try to drop and re-create the indexes every time the diff is run.
So this solves index churn in schema diffs on SQL server.