Add test for schema diffing on a table with a renamed foreign key column referencing a renamed table #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1246 We use Jira to track the state of pull requests and the versions they got |
|
@zeroedin-bill I'm sorry but this requires a rebase now. |
…tables have their FK constraints properly removed.
billschaller
force-pushed
the
fix-fk-schemadiff-renamed-column
branch
from
bd92239 to
bdb2f2d
Compare
|
@deeky666 Somewhere upstream this was fixed, so I just pared down this pr to the added test and squashed commits. |
billschaller
changed the title
|
@zeroedin-bill I think this has been addressed here: #861 |
deeky666
added a commit
that referenced
this pull request
Jan 12, 2016
…column Add test for schemadiff on table with renamed fk column referencing renamed table
|
@zeroedin-bill Thanks! |
Ocramius
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situations where SQL is generated with SchemaDiff::toSaveSql, foreign keys for columns that have been renamed or removed were not being dropped if the referenced table was orphaned.This PR adds a test to ensure that when a table should be renamed, and the FK columns referencing it should also be renamed, the FKs are properly removed and readded. This PR formerly fixed an issue where this was not successful, but it has since been fixed upstream, so this PR has just been pared back to the added test.