Add Mysql per-column charset support #881
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1264 We use Jira to track the state of pull requests and the versions they got |
|
👍 |
| - **collate** (string): The collation to use for the column. Currently only supported on | ||
| SQL Server. | ||
| - **collation** (string): The collation to use for the column. Supported by MySQL, PostgreSQL, | ||
| Sqlite, SQL Server and Drizzle. |
There was a problem hiding this comment.
Docs fix is correct, but is unrelated to this PR. Please PR this separately.
There was a problem hiding this comment.
Doc fix removed from this PR
mRoca
force-pushed
the
feature/mysql-charset
branch
from
05aa0e2
to
632fa6a
Compare
mRoca
force-pushed
the
feature/mysql-charset
branch
from
632fa6a
to
adbccdf
Compare
| $columns = $this->_sm->listTableColumns('test_charset'); | ||
|
|
||
| $this->assertArrayNotHasKey('charset', $columns['id']->getPlatformOptions()); | ||
| $this->assertEquals('latin1', $columns['text']->getPlatformOption('charset')); |
There was a problem hiding this comment.
This looks wrong. The charset is set implicit here through the table's default charset. However why is it latin1 here? As far as I can see, we set it implicitly to utf8 here
There was a problem hiding this comment.
Nevermind, somehow didn't see that you're using custom table collation here.
There was a problem hiding this comment.
Yes, I've set the default table charset to latin1 : https://github.com/doctrine/dbal/pull/881/files#diff-921db63349be598a376afb1584ccc8b5R206, the test is verifying the default charset behavior.
|
👍 |
| @@ -199,6 +199,10 @@ protected function _getPortableTableColumnDefinition($tableColumn) | |||
|
|
|||
| $column = new Column($tableColumn['field'], Type::getType($type), $options); | |||
|
|
|||
| if (isset($tableColumn['characterset'])) { | |||
| $column->setPlatformOption('charset', $tableColumn['characterset']); | |||
There was a problem hiding this comment.
Why is the option named characterset instead of charset?
Hint: if I'm asking this, it means that at least a comment in the code is needed.
|
Closing this PR, as @altertable copied its content in #3418 |
Actually with MySQL we can define a collation per column, but the charset seems not supported, whereas specified in the documentation : http://doctrine-dbal.readthedocs.org/en/latest/reference/schema-representation.html#vendor-specific-options
I've added the
CHARACTER SET ***sql declation for the MySQL platform.Use case with Doctrine/ORM :
Linked PR : #850