#869 cleanups and hardening of tests around date-related types #902
Conversation
…ime formats to use `setExpectedException`
…ion exception signature
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1294 We use Jira to track the state of pull requests and the versions they got |
| $actualType, | ||
| $toType, | ||
| implode(', ', $possibleTypes) | ||
| )); |
There was a problem hiding this comment.
This makes vastly more sense than the nonsense I wrote.
|
The recently added DateTimeInterval type needs the same treatment. I can take care of that if needed. This is ready to merge. |
|
|
||
| class DateTest extends \Doctrine\Tests\DbalTestCase | ||
| class DateTestCase extends BaseDateTypeTestCase |
There was a problem hiding this comment.
Doesn't matter if nobody extends this (probably nobody will) but the class name doesn't match the filename anymore.
There was a problem hiding this comment.
Urgh, silly IDE did silly refactoring. Fixing.
… the `ConversionException`
| $this->_platform = new MockPlatform(); | ||
| $this->_type = Type::getType('dateinterval'); | ||
| $this->platform = new MockPlatform(); | ||
| $this->type = Type::getType('dateinterval'); |
There was a problem hiding this comment.
Assert $this->type is instance of Type
There was a problem hiding this comment.
done at Ocramius/dbal@155f5d7
|
Big 👍 Thanks! |
…` retrieves a `DateIntervalType` instance
…ersion-excessive-smartness Hotfix - #869 - fixes for type conversion logic
Ocramius
deleted the
hotfix/#869-fixes-for-type-conversion-excessive-smartness
branch
Ocramius
changed the title
See #869