Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tearDown of some functional test cases #904

Merged

Conversation

deeky666
Copy link
Member

The manual tear down of some test cases doesn't work if an exception is thrown before expecting it, thus making following test fail also. See here

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-1297

We use Jira to track the state of pull requests and the versions they got
included in.

@deeky666 deeky666 force-pushed the fix-functional-exception-test branch from c5b7757 to 3025878 Compare September 10, 2015 17:00
@billschaller
Copy link
Member

👍

billschaller pushed a commit that referenced this pull request Sep 10, 2015
Fix tear down of some functional exception test cases
@billschaller billschaller merged commit 9ea8b0a into doctrine:master Sep 10, 2015
@billschaller billschaller self-assigned this Sep 10, 2015
@deeky666 deeky666 deleted the fix-functional-exception-test branch July 7, 2016 07:27
@Ocramius Ocramius changed the title Fix tear down of some functional exception test cases Fix tearDown of some functional test cases Jul 22, 2017
@Ocramius Ocramius added this to the 2.6 milestone Jul 22, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants