Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type of Table::renameColumn() and mark it as deprecated #916

Merged
merged 1 commit into from
Oct 12, 2015
Merged

Conversation

aivus
Copy link
Contributor

@aivus aivus commented Oct 12, 2015

What do you think, I should use @deprecated or @internal here?

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-1318

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius
Copy link
Member

@aivus @deprecated is correct, thanks!

@Ocramius Ocramius self-assigned this Oct 12, 2015
Ocramius added a commit that referenced this pull request Oct 12, 2015
Fix return type and mark as deprecated for Table::renameColumn
@Ocramius Ocramius merged commit 532641f into doctrine:master Oct 12, 2015
@aivus aivus deleted the patch-1 branch October 12, 2015 14:55
@Ocramius Ocramius added this to the 2.6 milestone Jul 22, 2017
@Ocramius Ocramius changed the title Fix return type and mark as deprecated for Table::renameColumn Fix return type of Table::renameColumn() and mark it as deprecated Jul 22, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants