Make members of filters and strategies private #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution: BC Break
This makes member os filters and strategies private.
For
PropertyName
filterThe members
properties
andexclude
are now private. As the class itself is markedfinal
, this doesn't have any consequences. No getter/setter methods are provided.For
AbstractCollectionStrategy
The members which are are now private are:
collectionName
-> usesetCollectionName()
/getCollectionName()
insteadclassMetadata
-> usesetClassMetadata()
/getClassMetadata()
insteadobject
-> usesetObject()
/getObject()
insteadinflector
-> usegetInflector()
instead, or set inflector using the constructorWhile
AbstractCollectionStrategy
is marked asinternal
in 3.x, it wasn't internal in 2.x, so this will be a BC break for users upgrading from 2.x who have implemented their own strategies extending fromAbstractCollectionStrategy
.