Add PHP 8.2 support #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fezfez
force-pushed
the
php8.2
branch
2 times, most recently
from
4b15fec to
48dfb9d
Compare
|
Looks like |
|
I dropped |
Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
done |
|
@driehle seem to be good :) |
|
Looks good, but I a wondering if we should add a test case for readonly properties (PHP 8.1) and readonly classes (PHP 8.2). As uninitialized properties are ignored for extraction by reference... ... readonly properties could be ignored for hydration by reference. What do you think? |
|
@driehle tests has beed added :) |
driehle
requested changes
Nov 17, 2022
2 tasks
|
@driehle should be ok |
driehle
approved these changes
Nov 18, 2022
|
Thanks, @fezfez, for you time and contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stéphane Demonchaux demonchaux.stephane@gmail.com